Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing over/under-delimiters #3856

Open
Enivex opened this issue Apr 3, 2024 · 2 comments
Open

Add missing over/under-delimiters #3856

Enivex opened this issue Apr 3, 2024 · 2 comments
Labels
feature request New feature or request math Related to math syntax, layout, etc.

Comments

@Enivex
Copy link
Collaborator

Enivex commented Apr 3, 2024 •
edited

While looking at #3564 I realized that there are some obvious missing functions from https://typst.app/docs/reference/math/underover

In particular underparen (U+023DD) and overparen (U+023DC)

For completeness there's also the tortoise shell brackets U+023E0 (top) and U+023E1 (bottom). Apparently they're called obrbrak and ubrbrak in LaTeX. If we add them I propose we use different names. undershell and overshell perhaps?
@Enivex Enivex added feature request New feature or request math Related to math syntax, layout, etc. labels Apr 3, 2024
@frozolotl
Copy link
Contributor

frozolotl commented Apr 3, 2024 •
edited

I actually did write such a commit before #3564, but did not upstream it because I did not find them to be often used in LaTeX. My search was very quick and very rudimentary though.
I'll create a PR later.

@Enivex
Copy link
Collaborator Author

Enivex commented Apr 3, 2024 •
edited

I actually did write such a commit before #3564, but did not upstream it because I did not find them to be often used in LaTeX. My search was very quick and very rudimentary though.
I'll create a PR later.

Even things not used that often will be used by someone, and that someone will ask for them. May as well get it done before it comes to that, especially when it's something relatively simple like this.

That's my stance at least.

@frozolotl frozolotl mentioned this issue Apr 4, 2024
Closed
frozolotl added a commit to frozolotl/typst that referenced this issue Apr 4, 2024
@frozolotl
I decided to use the word shell instead of turtle or tortoise becau…
6a8f1d2 
…se I

think it is a bit clearer, the word reads nicer (“overshell” vs “overturtle”),
and there is no associated discussion (they are called “tortoise shells” in
Unicode):

> tortoises and turtles are not the same thing!
~ @Enivex

There will be a sibling PR to rename the symbols too.

Additionally, I refactored some code to make it more readable.
I also fixed a bug introduced in typst#3262 where the wrong script style was being used.

Closes typst#3856.
frozolotl added a commit to frozolotl/typst that referenced this issue Apr 4, 2024
@frozolotl
Implement under/over parens/shells, refactor code
394f5aa 
I decided to use the word `shell` instead of turtle or tortoise because I
think it is a bit clearer, the word reads nicer (“overshell” vs “overturtle”),
and there is no associated discussion (they are called “tortoise shells” in
Unicode):

> tortoises and turtles are not the same thing!
~ @Enivex

There will be a sibling PR to rename the symbols too.

Additionally, I refactored some code to make it more readable.
I also fixed a bug introduced in typst#3262 where the wrong script style was being used.

Closes typst#3856.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request math Related to math syntax, layout, etc.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement under/over parens/shells, refactor code frozolotl/typst
2 participants
@Enivex @frozolotl