Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

publisher should be an object #34

Open
denismaier opened this issue Mar 25, 2023 · 1 comment · May be fixed by #105
Open

publisher should be an object #34

denismaier opened this issue Mar 25, 2023 · 1 comment · May be fixed by #105

Comments

@denismaier
Copy link

Hey, I've just had a quick look at this project and it certainly looks interesting. I think using parent items instead of using parent-title etc. is a good choice.
One thing to consider though: I suggest making publishers an object with attributes: name and location. Because there are rare cases where a book is being published by two publishers that each gave their own location.
You will want to render this as:
Location A: Publisher A; Location B: Publisher B

We've had some discussions about this over at the CSL repo, and a similar change is planned, but it's much easier to make such a design decision when there's still not much technical debt...

@reknih
Copy link
Member

reknih commented Mar 25, 2023

Good rationale, I like it! Will try to implement once I have the bandwidth

@DerDrodt DerDrodt linked a pull request Dec 13, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants