Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create controllers in specified order #775

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

getfatday
Copy link

Description

Controllers are created in the order they are passed into the router controller options, not in the order they are registered with metadata

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

Fixes

Fixes #774

@getfatday getfatday changed the title fix(controller): create controllers in specified order fix: create controllers in specified order Sep 16, 2021
@dantaeusb
Copy link

I faced the same problem that mentioned in #774 in a bit different manner.
I agree that import ordering in server bootstrap is counter-intuitive and hope this will be merged, or at least there'll be some explanation in docs for @Controller and @{Method} parametrized decorators.

@alexberriman
Copy link

+1 for this. Frustrating and counter intuitive.

@attilaorosz
Copy link
Member

This is reasonable and I agree with the solution, but this might be breaking for some people who rely solely on the workaround. @NoNameProvided thoughts?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

fix: create controllers in specified order
4 participants