Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: jsdoc for Put http method, it mentions POST http method #1230

Open
kalvarez2 opened this issue Sep 23, 2023 · 0 comments
Open

fix: jsdoc for Put http method, it mentions POST http method #1230

kalvarez2 opened this issue Sep 23, 2023 · 0 comments
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.

Comments

@kalvarez2
Copy link
Contributor

kalvarez2 commented Sep 23, 2023 •
edited

Description

The current js doc for the Put() decorator mistakenly says POST when it should say PUT

Minimal code-snippet showcasing the problem

routing-controllers/src/decorator/Put.ts

Line 11 in 9cd3ff7

* Registers an action to be executed when POST request comes on a given route.

routing-controllers/src/decorator/Put.ts

Line 17 in 9cd3ff7

* Registers an action to be executed when POST request comes on a given route.

Expected behavior

It should say PUT

Actual behavior

js doc for Put method is wrong
@kalvarez2 kalvarez2 added status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature. labels Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: needs triage Issues which needs to be reproduced to be verified report. type: fix Issues describing a broken feature.
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kalvarez2