Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use es6-symbol to ponyfill Symbol #48

Closed
wants to merge 2 commits into from
Closed

Use es6-symbol to ponyfill Symbol #48

wants to merge 2 commits into from

Conversation

tjaneczko
Copy link
Contributor

This PR uses es6-symbol to ponyfill Symbol instead of overriding the global Symbol in typed.js. Added tests to ensure that this fixes using Symbol or Symbols as types.

Resolves #47

@tjaneczko tjaneczko closed this Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Symbol polyfill overwrites native Symbol type in typed.js
1 participant
@tjaneczko