Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symbol polyfill overwrites native Symbol type in typed.js #47

Open
tjaneczko opened this issue Aug 12, 2018 · 0 comments
Open

Symbol polyfill overwrites native Symbol type in typed.js #47

tjaneczko opened this issue Aug 12, 2018 · 0 comments

Comments

@tjaneczko
Copy link
Contributor

The polyfill for Symbol (https://github.com/typed-immutable/typed-immutable/blob/master/src/typed.js#L3) always overwrites the native Symbol type since the var declaration is hoisted outside of the if statement, so that polyfill actually will act as the following:

var Symbol
if (typeof(Symbol) === 'undefined') {
  Symbol = hint => `@@${hint}`
  Symbol.for = Symbol
}

This means that you cannot use Symbol as a type, i.e. Map(Symbol, String) will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant