Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove findDOMNode in about-us page #1899

Open
taylrj opened this issue Jul 9, 2021 · 0 comments
Open

Remove findDOMNode in about-us page #1899

taylrj opened this issue Jul 9, 2021 · 0 comments
Labels
help wanted

Comments

@taylrj
Copy link
Contributor

taylrj commented Jul 9, 2021 •
edited

Currently, when running make lint in this repo, it still suffers from react/no-find-dom-node warnings:
image

The reason we want to have no warning when using eslint --fix is we'd like to enable the linter on CI but the warnings will break it.

To be precise, we need to refactor away use of the deprecated API findDOMNode in about-us page.

Related thread: #1877
@taylrj taylrj pinned this issue Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@taylrj