fix: clear lastAssigned when revoking eager consumer #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tried writing a test for this but wasn't able to write one that properly exercised the code path here :( Instead we've manually tested this fix by running consumers locally from this minimal repro: https://github.com/hamdanjaveed/kgo-cooperative-bug-reproducer |
twmb
approved these changes
May 8, 2024
|
Sorry for the delay, the last few months were much busier than anticipated. Releasing imminently! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a consumer that can be cooperative but is currently eager revokes its assigned partitions as part of a rebalance it should also clear its tracking state between rebalances as it has revoked all of its partitions.
This was leading to some inconsistent behaviour when migrating from eager consumers to cooperative consumers following the migration instructions in KIP-429.
Fixes #686