Did tcpkeepalive make it into the current codebase?

[jennyfountain]

I am see a couple references to it in issues and thought I saw a merge but do not see documentation.

Thanks

[manjuraj]

twemproxy/src/nc_proxy.c

Lines 361 to 365 in 74af2fb

	if (pool->tcpkeepalive) {
	status = nc_set_tcpkeepalive(c->sd);
	if (status < 0) {
	log_warn("set tcpkeepalive on c %d from p %d failed, ignored: %s",
	c->sd, p->sd, strerror(errno));

[manjuraj]

https://github.com/twitter/twemproxy/search?utf8=%E2%9C%93&q=tcpkeepalive

[jennyfountain]

@manjuraj Perfect I thought so after reviewing myself but I don't' trust my eyes sometimes :D

This the doc information?

tcpkeepalive: A boolean value that controls if tcp keepalive enabled. Defaults to false.
tcpkeepidle: The time value in msec that a connection is in idle, and then twemproxy check this connection whether dead or not.
tcpkeepcnt: The number of tcpkeepalive attempt check if one idle connection dead times when the client always had no reply.
tcpkeepintvl: The time value in msec that the interval between every tcpkeepalive check when the client always had no reply.

[TysonAndre]

The work on redis sentinel also includes lowering the tcpkeepalive timeout in support set keepalive interval parameter in #324 , so more updates to keepalive behavior will probably be in an upcoming twitter/twemproxy 0.6.0 release

#608 is merging in changes from https://github.com/ifwe/twemproxy , which included 324 and patches to 324.

Closing this because Did tcpkeepalive make it into the current codebase? was answered