-
Notifications
You must be signed in to change notification settings - Fork 12.2k
/
WritePathHydration.scala
223 lines (202 loc) · 8.69 KB
/
WritePathHydration.scala
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
package com.twitter.tweetypie
package config
import com.twitter.servo.util.FutureArrow
import com.twitter.stitch.Stitch
import com.twitter.tweetypie.core._
import com.twitter.tweetypie.handler.TweetBuilder
import com.twitter.tweetypie.handler.WritePathQueryOptions
import com.twitter.tweetypie.hydrator.EscherbirdAnnotationHydrator
import com.twitter.tweetypie.hydrator.LanguageHydrator
import com.twitter.tweetypie.hydrator.PlaceHydrator
import com.twitter.tweetypie.hydrator.ProfileGeoHydrator
import com.twitter.tweetypie.hydrator.TweetDataValueHydrator
import com.twitter.tweetypie.repository._
import com.twitter.tweetypie.store.InsertTweet
import com.twitter.tweetypie.store.UndeleteTweet
import com.twitter.tweetypie.thriftscala._
import com.twitter.tweetypie.util.EditControlUtil
object WritePathHydration {
type HydrateQuotedTweet =
FutureArrow[(User, QuotedTweet, WritePathHydrationOptions), Option[QuoteTweetMetadata]]
case class QuoteTweetMetadata(
quotedTweet: Tweet,
quotedUser: User,
quoterHasAlreadyQuotedTweet: Boolean)
private val log = Logger(getClass)
val UserFieldsForInsert: Set[UserField] =
TweetBuilder.userFields
val AllowedMissingFieldsOnWrite: Set[FieldByPath] =
Set(
EscherbirdAnnotationHydrator.hydratedField,
LanguageHydrator.hydratedField,
PlaceHydrator.HydratedField,
ProfileGeoHydrator.hydratedField
)
/**
* Builds a FutureArrow that performs the necessary hydration in the write-path for a
* a InsertTweet.Event. There are two separate hydration steps, pre-cache and post-cache.
* The pre-cache hydration step performs the hydration which is safe to cache, while the
* post-cache hydration step performs the hydration whose results we don't want to cache
* on the tweet.
*
* TweetInsertEvent contains two tweet fields, `tweet` and `internalTweet`. `tweet` is
* the input value used for hydration, and in the updated InsertTweet.Event returned by the
* FutureArrow, `tweet` contains the post-cache hydrated tweet while `internalTweet` contains
* the pre-cache hydrated tweet.
*/
def hydrateInsertTweetEvent(
hydrateTweet: FutureArrow[(TweetData, TweetQuery.Options), TweetData],
hydrateQuotedTweet: HydrateQuotedTweet
): FutureArrow[InsertTweet.Event, InsertTweet.Event] =
FutureArrow { event =>
val cause = TweetQuery.Cause.Insert(event.tweet.id)
val hydrationOpts = event.hydrateOptions
val isEditControlEdit = event.tweet.editControl.exists(EditControlUtil.isEditControlEdit)
val queryOpts: TweetQuery.Options =
WritePathQueryOptions.insert(cause, event.user, hydrationOpts, isEditControlEdit)
val initTweetData =
TweetData(
tweet = event.tweet,
sourceTweetResult = event.sourceTweet.map(TweetResult(_))
)
for {
tweetData <- hydrateTweet((initTweetData, queryOpts))
hydratedTweet = tweetData.tweet
internalTweet =
tweetData.cacheableTweetResult
.map(_.value.toCachedTweet)
.getOrElse(
throw new IllegalStateException(s"expected cacheableTweetResult, e=${event}"))
optQt = getQuotedTweet(hydratedTweet)
.orElse(event.sourceTweet.flatMap(getQuotedTweet))
hydratedQT <- optQt match {
case None => Future.value(None)
case Some(qt) => hydrateQuotedTweet((event.user, qt, hydrationOpts))
}
} yield {
event.copy(
tweet = hydratedTweet,
_internalTweet = Some(internalTweet),
quotedTweet = hydratedQT.map { case QuoteTweetMetadata(t, _, _) => t },
quotedUser = hydratedQT.map { case QuoteTweetMetadata(_, u, _) => u },
quoterHasAlreadyQuotedTweet = hydratedQT.exists { case QuoteTweetMetadata(_, _, b) => b }
)
}
}
/**
* Builds a FutureArrow for retrieving a quoted tweet metadata
* QuotedTweet struct. If either the quoted tweet or the quoted user
* isn't visible to the tweeting user, the FutureArrow will return None.
*/
def hydrateQuotedTweet(
tweetRepo: TweetRepository.Optional,
userRepo: UserRepository.Optional,
quoterHasAlreadyQuotedRepo: QuoterHasAlreadyQuotedRepository.Type
): HydrateQuotedTweet = {
FutureArrow {
case (tweetingUser, qt, hydrateOptions) =>
val tweetQueryOpts = WritePathQueryOptions.quotedTweet(tweetingUser, hydrateOptions)
val userQueryOpts =
UserQueryOptions(
UserFieldsForInsert,
UserVisibility.Visible,
forUserId = Some(tweetingUser.id)
)
Stitch.run(
Stitch
.join(
tweetRepo(qt.tweetId, tweetQueryOpts),
userRepo(UserKey.byId(qt.userId), userQueryOpts),
// We're failing open here on tflock exceptions since this should not
// affect the ability to quote tweet if tflock goes down. (although if
// this call doesn't succeed, quote counts may be inaccurate for a brief
// period of time)
quoterHasAlreadyQuotedRepo(qt.tweetId, tweetingUser.id).liftToTry
)
.map {
case (Some(tweet), Some(user), isAlreadyQuoted) =>
Some(QuoteTweetMetadata(tweet, user, isAlreadyQuoted.getOrElse(false)))
case _ => None
}
)
}
}
/**
* Builds a FutureArrow that performs any additional hydration on an UndeleteTweet.Event before
* being passed to a TweetStore.
*/
def hydrateUndeleteTweetEvent(
hydrateTweet: FutureArrow[(TweetData, TweetQuery.Options), TweetData],
hydrateQuotedTweet: HydrateQuotedTweet
): FutureArrow[UndeleteTweet.Event, UndeleteTweet.Event] =
FutureArrow { event =>
val cause = TweetQuery.Cause.Undelete(event.tweet.id)
val hydrationOpts = event.hydrateOptions
val isEditControlEdit = event.tweet.editControl.exists(EditControlUtil.isEditControlEdit)
val queryOpts = WritePathQueryOptions.insert(cause, event.user, hydrationOpts, isEditControlEdit)
// when undeleting a retweet, don't set sourceTweetResult to enable SourceTweetHydrator to
// hydrate it
val initTweetData = TweetData(tweet = event.tweet)
for {
tweetData <- hydrateTweet((initTweetData, queryOpts))
hydratedTweet = tweetData.tweet
internalTweet =
tweetData.cacheableTweetResult
.map(_.value.toCachedTweet)
.getOrElse(
throw new IllegalStateException(s"expected cacheableTweetResult, e=${event}"))
optQt = getQuotedTweet(hydratedTweet)
.orElse(tweetData.sourceTweetResult.map(_.value.tweet).flatMap(getQuotedTweet))
hydratedQt <- optQt match {
case None => Future.value(None)
case Some(qt) => hydrateQuotedTweet((event.user, qt, hydrationOpts))
}
} yield {
event.copy(
tweet = hydratedTweet,
_internalTweet = Some(internalTweet),
sourceTweet = tweetData.sourceTweetResult.map(_.value.tweet),
quotedTweet = hydratedQt.map { case QuoteTweetMetadata(t, _, _) => t },
quotedUser = hydratedQt.map { case QuoteTweetMetadata(_, u, _) => u },
quoterHasAlreadyQuotedTweet = hydratedQt.exists { case QuoteTweetMetadata(_, _, b) => b }
)
}
}
/**
* Converts a TweetDataValueHydrator into a FutureArrow that hydrates a tweet for the write-path.
*/
def hydrateTweet(
hydrator: TweetDataValueHydrator,
stats: StatsReceiver,
allowedMissingFields: Set[FieldByPath] = AllowedMissingFieldsOnWrite
): FutureArrow[(TweetData, TweetQuery.Options), TweetData] = {
val hydrationStats = stats.scope("hydration")
val missingFieldsStats = hydrationStats.scope("missing_fields")
FutureArrow[(TweetData, TweetQuery.Options), TweetData] {
case (td, opts) =>
Stitch
.run(hydrator(td, opts))
.rescue {
case ex =>
log.warn("Hydration failed with exception", ex)
Future.exception(
TweetHydrationError("Hydration failed with exception: " + ex, Some(ex))
)
}
.flatMap { r =>
// Record missing fields even if the request succeeds)
for (missingField <- r.state.failedFields)
missingFieldsStats.counter(missingField.fieldIdPath.mkString(".")).incr()
if ((r.state.failedFields -- allowedMissingFields).nonEmpty) {
Future.exception(
TweetHydrationError(
"Failed to hydrate. Missing Fields: " + r.state.failedFields.mkString(",")
)
)
} else {
Future.value(r.value)
}
}
}
}.trackOutcome(stats, (_: Any) => "hydration")
}