Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiImporter warnings for duplicates due to root importer #344

Closed
muuki88 opened this issue Mar 11, 2021 · 1 comment
Closed

MultiImporter warnings for duplicates due to root importer #344

muuki88 opened this issue Mar 11, 2021 · 1 comment

Comments

@muuki88
Copy link
Contributor

muuki88 commented Mar 11, 2021

Since our upgrade to 21.2.0 we see hundreds of warnings due to Expected to find just 1 match for <... thrift file name... >.

We have multi module setups and this line is responsible for the new warnings.

val importer = Importer(new File(".")) +: Importer(config.includePaths.toSeq)

The root directory ( new File(".") ) is always added as an importer, which in multi module scenarios means that the every file can be found twice.

root/
  api/
    src/main/thrift/services.thrift

Produces the following warning

WARN: Expected to find just 1 match for /root/api/src/main/thrift/services.thrift, but found 2, in DirImporter(/root), DirImporter(/root/api/src/main/thrift/)
@muuki88
Copy link
Contributor Author

muuki88 commented Mar 11, 2021

Sorry, just saw #341

@muuki88 muuki88 closed this as completed Mar 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant