Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on hogan.js homepage assumes Array.prototoype.map mutates original array #251

Open
g-patel opened this issue Aug 29, 2016 · 1 comment
Assignees

Comments

@g-patel
Copy link

g-patel commented Aug 29, 2016

Documentation on hogan.js homepage (http://twitter.github.io/hogan.js/) assumes Array.prototoype.map mutates original array which is not true.

Note: Please move to the documentation (for homepage) repo if there is one. I could not find a one, so filing an issue on this repo.

This is a minor issue, but might confuse developers about Array.prototype.map.

Following won't work:
console.log('Follow: ' + team.join(' ') + '!');

To correct the doc, result of team.map() call needs to be stored in a variable, and then join() should be called on that variable.

image

@g-patel g-patel changed the title Documentation on hogan.js homepage (http://twitter.github.io/hogan.js/) assumes Array.prototoype.map mutates original array which is not true. Documentation on hogan.js homepage (http://twitter.github.io/hogan.js/) assumes Array.prototoype.map mutates original array Aug 29, 2016
@g-patel g-patel changed the title Documentation on hogan.js homepage (http://twitter.github.io/hogan.js/) assumes Array.prototoype.map mutates original array Documentation on hogan.js homepage assumes Array.prototoype.map mutates original array Aug 29, 2016
@g-patel
Copy link
Author

g-patel commented Sep 9, 2016

Is there any update on the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants