Switch to go modules and initialize v8 of the project #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Opened this to start a conversation around our go modules approach. Looks fairly heavy handed in terms of folks providing libraries that wrap twirp. They will have to update their libraries every major version release which is not ideal. Exploring a few things so folks won't need to. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets up go modules for this repository and changes the base version to v8.
Additionally, this removes the checked in
vendorfolder of the project.This resolves #169
Changes to imports
Imports are now updated to
github.com/twitchtv/twirp/v8for users ofv8.0.0and above.Other than that, no major changes for even users of
depas long as they are using a version ofgo > LATEST - 3.Future major revisions will need to go into the
./v9folder of the repository if there comes a need for another major revision.Disclaimer
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.