Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Confirmation message is incorrect if "closeProtection" is enabled. #243

Open
8 tasks done
yanniel opened this issue Feb 8, 2024 · 0 comments
Open
8 tasks done
Labels
bug Something isn't working

Comments

@yanniel
Copy link

yanniel commented Feb 8, 2024

  • I have verified that the issue occurs with the latest twilio.js release and is not marked as a known issue in the CHANGELOG.md.
  • I reviewed the Common Issues and open GitHub issues and verified that this report represents a potentially new issue.
  • I verified that the Quickstart application works in my environment.
  • I am not sharing any Personally Identifiable Information (PII)
    or sensitive account information (API keys, credentials, etc.) when reporting this issue.

Code to reproduce the issue:

    const voiceClient = new Device(twilioAccessToken, {
      closeProtection: true,
    });

Expected behavior:

The confirmation message should be: "A call is currently in-progress. Leaving or reloading this page will end the call."

Actual behavior:

The confirmation message that's displayed is "Changes you made may not be saved."

Software versions:

  • Browser(s): Google Chrome. Version 121.0.6167.160 (Official Build) (arm64)
  • Operating System: macOS Sonoma 14.3
  • twilio.js: 2.10.1
  • Third-party libraries (e.g., Angular, React, etc.): "react": "^17.0.2",
@yanniel yanniel added the bug Something isn't working label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant