Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to npm workspaces #114

Closed
wants to merge 1 commit into from
Closed

Switch to npm workspaces #114

wants to merge 1 commit into from

Conversation

XhmikosR
Copy link
Member

@XhmikosR XhmikosR commented Mar 22, 2023 •
edited

TODO:

Notes:

  • the CI patch is less code to maintain but it might be nice to have separate CI runs per project, so I might drop it
  • I used a wildcard in the root package.json to keep it simple
  • later we could probably move some common scripts in the root package.json if needed

Fixes #96

StackBlitz links:

@XhmikosR XhmikosR mentioned this pull request Mar 22, 2023
Closed
@XhmikosR XhmikosR force-pushed the xmr/workspaces branch 29 times, most recently from ae35dff to 1dd94f8 Compare March 24, 2023 08:24
@XhmikosR XhmikosR force-pushed the xmr/workspaces branch 6 times, most recently from 4401473 to 1814f92 Compare March 28, 2023 07:37
@XhmikosR
Copy link
Member Author

XhmikosR commented Mar 28, 2023 •
edited

I'm going to have to drop this idea, unfortunately, since I can't make relative paths to work properly locally and on StackBlitz :/

Basically these packages are broken in this branch due to the hardcoded paths:

  • color-modes
  • icons-font
  • sass-js
  • sass-js-esm

The other packages seem to work fine, though.

It would help maintenance a lot, so if anyone has any ideas let me know, otherwise let's drop this PR.

/CC @julien-deramond @kyletsang

@kyletsang
Copy link
Contributor

I'm going to have to drop this idea, unfortunately, since I can't make relative paths to work properly locally and on StackBlitz :/

Basically these packages are broken in this branch due to the hardcoded paths:

* color-modes

* icons-font

* sass-js

* sass-js-esm

The other packages seem to work fine, though.

It would help maintenance a lot, so if anyone has any ideas let me know, otherwise let's drop this PR.

/CC @julien-deramond @kyletsang

I think we should copy the required assets into the project directory as part of some pre-build script. So something like this in the icons-font project:

package.json

"copy-assets": "shx rm -rf dist && shx mkdir -p ./dist/bootstrap-icons && shx cp -r ../../node_modules/bootstrap-icons ./dist",

styles.scss

$bootstrap-icons-font-dir: "../dist/bootstrap-icons/font/fonts";
@import "bootstrap-icons/font/bootstrap-icons";

@kyletsang kyletsang mentioned this pull request Apr 1, 2023
Closed
@XhmikosR
Copy link
Member Author

XhmikosR commented Apr 2, 2023

Closing per #155

@XhmikosR XhmikosR closed this Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Explore switching to npm workspaces
2 participants
@XhmikosR @kyletsang