Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Major release: v2 #78

Open
5 tasks
Acconut opened this issue Jan 17, 2023 · 8 comments
Open
5 tasks

Major release: v2 #78

Acconut opened this issue Jan 17, 2023 · 8 comments

Comments

@Acconut
Copy link
Member

Acconut commented Jan 17, 2023

Major changes:

Additional features:

@lealceldeiro
Copy link

Hey, @Acconut , could you share an ETA for this release?

@Acconut
Copy link
Member Author

Acconut commented Feb 6, 2023

Sorry, we do not have any schedule available to share. Explicit work on this has not yet started.

@LaravZ
Copy link

LaravZ commented Mar 6, 2023

Hi @Acconut,

Would it be possible to add support for proxies earlier than v2 if I were to contribute code in a PR? I don't wish to override code in multiple places or use system settings to accomplish this.

I believe the change would be rather simple if we use java.net.Proxy.NO_PROXY as a default.

@Acconut
Copy link
Member Author

Acconut commented Mar 6, 2023

Yes, of course! Feel free to open a PR for this.

@pdenooijer
Copy link
Contributor

@Acconut we could fix this pretty quickly and robust. Would you be open to review the code (provided we create a PR), merge it (after comments are resolved) and create a new release? The lack of this feature is blocking our implementation. We're behind a proxy for external connections, but don't want to use it for all request as most of them are local.

As said in #52 (comment).

@Acconut
Copy link
Member Author

Acconut commented Mar 6, 2023

Yes, sure. We are always happy to accept PRs.

@piotrblasiak
Copy link

Any ETA on this? This library is currently unusable with cloudflare because of the HTTP client apparently.

@Acconut
Copy link
Member Author

Acconut commented Mar 6, 2024

No ETA, but we will bump it up on our priority list.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants