Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest Retail version shows spells as usable, incorrectly. (10.1.6) #32

Open
arcadepro opened this issue Jul 18, 2023 · 3 comments
Open
Assignees
Labels

Comments

@arcadepro
Copy link

arcadepro commented Jul 18, 2023

Current version (10.1.5/6 Retail) is little buggy. It causes spells on your bar to light up/desaturate incorrectly.

Skullsplitter (warrior) is fully lit when its on your bar but untalented.
Execute (warrior) also is commonly fully saturated when unusable. Hovering over an incorrectly saturated Execute button causes it to update and fix its status temporarily.

This occurs whether the the Tullarange desaturate option is being used or not. So something is causing buttons to go full saturation incorrectly. Removing TullaRange causes execute (and other abilities) to function correctly.

Either it's the new event or the logic is a little wonky somewhere.

10.1.0 functions correctly.

@rakkarage
Copy link

rakkarage commented Jul 26, 2023

Same problem.

WoWScrnShot_072623_113802
Execute is not usable here. But looks like it is.

I tested with no addons and works fine. Enabled only tullaRange and problem is back.

A slight workaround it to make a wa glow the button when really ready.

Thanks.

@rakkarage
Copy link

testing with execute as spell instead of macro (happens with both but maybe bit different)

  • mouse over fixes it!? when looks usable mouse over changes to actual state, not usable
  • not happen if right click to start attacking up close but happens when charge
    • quick range and power change?

in actionButton_UpdateColor
execute seems to normally return usable=false oom=false oor=false
when i charge changes to usable=false oom=false oor=true
when i mouse over changes back to usable=false oom=false oor=false
so seems like should not show as usable? but does? idk

i guess actionButton_UpdateColor needs to be called again or more often? idk
adding hook to Update or OnUpdate as well seems to fix it soon after charge?

hooksecurefunc(button, "UpdateUsable", actionButton_UpdateUsable)
hooksecurefunc(button, "Update", actionButton_UpdateUsable)
hooksecurefunc(button, "OnUpdate", actionButton_UpdateUsable)

thanks

@Tuller
Copy link
Member

Tuller commented Oct 7, 2023

Blizzard is making some updates to usability changes in 10.2 so that it becomes more event based like range checking is now. I’m waiting to see if that resolves any of the issues

@Tuller Tuller added the bug label Oct 7, 2023
@Tuller Tuller self-assigned this Oct 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants