Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release version 3.0 #245

Open
2 tasks
ttu opened this issue Feb 19, 2024 · 9 comments
Open
2 tasks

Release version 3.0 #245

ttu opened this issue Feb 19, 2024 · 9 comments
Assignees

Comments

@ttu
Copy link
Owner

ttu commented Feb 19, 2024

@ttu ttu self-assigned this Feb 19, 2024
@terop
Copy link
Contributor

terop commented Feb 19, 2024

I created a commit for item two in the above list, it can be found at terop@757b441.
@ttu please take a look in case I missed something and if something should be change or improved.

@ttu
Copy link
Owner Author

ttu commented Feb 24, 2024

Thanks, commit looks good. I will leave comments if something comes to mind that is missing.

I was thinking that we should also drop support for 3.8 with this release. Its end of life is in October 2024, so by the time of the release, it won't be that far away. Based on the PyPI stats, it is not very widely used.

@terop
Copy link
Contributor

terop commented Feb 24, 2024

So is the plan to wait for October to make the release or also remove 3.8 support before official support ends (and not wait for October)?

@ttu
Copy link
Owner Author

ttu commented Feb 26, 2024

There is no need to wait for the official support to end. Based on current pypistats, most installations are from Python 3.10 and above.

There will be a final release for v2 with the fixes that have not yet been released, and after that, we can begin preparations for the v3 release.

@terop
Copy link
Contributor

terop commented Feb 26, 2024

Okay. I could then add another commit for the removal of Python 3.8.

@terop
Copy link
Contributor

terop commented Feb 27, 2024

I rebased my branch from master and now it contains the following commits.
Python 3.7 support removal: terop@b3658eb
Python 3.8 support removal: terop@0c94840

@terop
Copy link
Contributor

terop commented Mar 11, 2024

@ttu Could you kindly check the above commits?

@ttu
Copy link
Owner Author

ttu commented Apr 4, 2024

@terop sorry again for the delay. I think those commits already had pretty much all required changes. I found few mentions about default adapters that should be changed to Bleak, but after that I think those are good 👍

@terop
Copy link
Contributor

terop commented Apr 5, 2024

Thanks for the comments @ttu.
I fixed them as best I could and rebased the branch so now the commits are as follows:
Python 3.7 support removal: terop@133ee50
Python 3.8 support removal: terop@ec28465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants