Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if it is OK to use client_id as subject instead of key_key #57

Open
csev opened this issue May 12, 2019 · 1 comment
Open

Check if it is OK to use client_id as subject instead of key_key #57

csev opened this issue May 12, 2019 · 1 comment

Comments

@csev
Copy link
Collaborator

csev commented May 12, 2019 •
edited

In Context::getGradeToken - we sent the subject as key_key on token requests - key_key was a Tsugi-made up string that was never part of the security contract prior to the issuer refactor. This passed the cert suite and interacted with all the LMSs successfully this way. Post the issuer refactor - this looks like it really means to be the client_id. Make sure after this change is tested to go into Context.php and cleanup all the TODOs.
@csev
Copy link
Collaborator Author

csev commented May 12, 2019

This looks to be working well with Sakai. I will test with other reference implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@csev