Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Officially call json input format JSON Lines? #682

Open
emerikaji opened this issue Feb 13, 2024 · 1 comment
Open

Officially call json input format JSON Lines? #682

emerikaji opened this issue Feb 13, 2024 · 1 comment

Comments

@emerikaji
Copy link

Hi,

After using the json input format for some load testing, I realized it would be considered valid json Lines input, since it consists of newline-separated JSON objects;
For clarity, and to improve the visibility of json Lines as well as its standardization, should the json input format be mentioned as json Lines in the Vegeta documentation? Without the context of the jsonl file format, passing multiple json objects like this rather than something like a list seems a little arbitrary.

@tsenart
Copy link
Owner

tsenart commented Feb 14, 2024

The format was defined without me knowing about JSON lines or NDJSON back then. Were they even a thing at that point?

It's definitely not arbitrary however — it's meant to be streamable, which a JSON array with objects in it isn't.

Happy to review a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants