Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listener.go is now missing the Call() function #3

Open
jbeisser opened this issue Nov 27, 2020 · 2 comments
Open

listener.go is now missing the Call() function #3

jbeisser opened this issue Nov 27, 2020 · 2 comments

Comments

@jbeisser
Copy link

the salt-cli-v2/salt.go client relies on s.Call() to pass commands to the salt-master. Some time ago listener.go lost the function.

In testing a custom client, returning the function appears to address the problem:

func (srv *Server) Call(tag string, respch chan Response) {
	srv.reqch <- request{tag: tag, respch: respch}
	fmt.Println("Added tag", tag)
}
@tsaridas
Copy link
Owner

tsaridas commented Jan 7, 2021

I believe the function was renamed to Register but I missed to change it in the v2 client. You can change your PR and I'll merge or I can do it at some point. Thanks for letting me know.

@jbeisser
Copy link
Author

jbeisser commented Jan 7, 2021

I'll dig around, and update the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants