Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include .thor files #1485

Open
mdi opened this issue Jul 17, 2019 · 4 comments
Open

Include .thor files #1485

mdi opened this issue Jul 17, 2019 · 4 comments
Labels

Comments

@mdi
Copy link

mdi commented Jul 17, 2019

Is there any way to get reek to analyze .thor files? They seem to be ignored no matter what.

@troessner
Copy link
Owner

Currently this is not possible. Unfortunately the file extension is hard-coded right now as you can see here:

      def ruby_file?(path)
        path.extname == '.rb'
      end

I would be up for either patching this functionality or making it a configurable setting. The latter would definitely be a bit of an effort though. @mvz thoughts?

@mvz
Copy link
Collaborator

mvz commented Jul 18, 2019

This is basically #721, right?

@troessner
Copy link
Owner

Good point. At least its closely related, yeah.

@mvz
Copy link
Collaborator

mvz commented Jul 18, 2019

I'll give this some thought over the weekend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants