Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace yaml-rust with yaml-rust2 in order to not be affected by RUSTSEC-2024-0320 #537

Open
d3rpp opened this issue May 1, 2024 · 3 comments
Milestone

Comments

@d3rpp
Copy link

d3rpp commented May 1, 2024

yaml-rust appears to be unmaintained, however, the community has published an actively maintained fork under the name of yaml-rust2, It is a drop in replacement.

Details on "Vulnerability" - RUSTSEC-2024-0320.

Assuming this isn't a duplicate (I could not find this being brought up before in this issues list), I will submit a PR dropping this in, it's a single line so assuming the developers of yaml-rust2 didn't change the API, shouldn't be an issue.

@d3rpp
Copy link
Author

d3rpp commented May 1, 2024

Update: it appears, yaml-rust isn't being used in the crate at all?

I'll submit a PR to run the update regardless, though it may be worth looking into removing it all together since the dependency doesn't seem to be referenced in the code at all.

@CosmicHorrorDev
Copy link
Contributor

Update: it appears, yaml-rust isn't being used in the crate at all?

It's used throughout this file

use yaml_rust::yaml::Hash;
use yaml_rust::{ScanError, Yaml, YamlLoader};

@d3rpp
Copy link
Author

d3rpp commented May 6, 2024

Update: it appears, yaml-rust isn't being used in the crate at all?

It's used throughout this file

use yaml_rust::yaml::Hash;
use yaml_rust::{ScanError, Yaml, YamlLoader};

Ah, my apologies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants