Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make region in S3 native file system optional #21795

Open
mosabua opened this issue May 1, 2024 · 3 comments
Open

Make region in S3 native file system optional #21795

mosabua opened this issue May 1, 2024 · 3 comments
Assignees

Comments

@mosabua
Copy link
Member

mosabua commented May 1, 2024

In some S3-compatible object storage systems the concept of a region as in S3 does not exist. One such example is MinIO. Currently users are forced to provide a fake value for region with these systems.

The desire is to make the region parameter optional. This could be done on the generic S3 level or potentially looking at creating separate levels for each "s3-compatible" system.

@mosabua
Copy link
Member Author

mosabua commented May 1, 2024

Assigning to @electrum as the file system lead.

@electrum
Copy link
Member

electrum commented May 1, 2024

The SDK v2 used to require region, but it looks like they have a cross region feature now: https://docs.aws.amazon.com/sdk-for-java/latest/developer-guide/s3-cross-region.html

@mosabua
Copy link
Member Author

mosabua commented May 1, 2024

But even if the SDK requires it .. we could shadow this in Trino and fill it in with some random value if minio is used, right?

Or we could just have a random and invalid default value. Then its essentially optional.. problem of course is that it is then quietly invalid for s3 users unless they fill it to correct the default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants