Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support and enable HTTP/2 #21793

Open
mosabua opened this issue May 1, 2024 · 6 comments
Open

Support and enable HTTP/2 #21793

mosabua opened this issue May 1, 2024 · 6 comments

Comments

@mosabua
Copy link
Member

mosabua commented May 1, 2024

As discussed in numerous contributor and maintainer meetings, we plan to move Trino towards HTTP/2. Patches to support that and use it in production exist already in the user and contributor community. Experience in terms of performance gains is very promising and a desire to have this feature in Trino itself is shared across numerous stakeholders.

This issue aims to pull the various efforts together and serve as communication tool.

Following are a couple of tasks and aspects to consider:

  • Upgrade to Jetty 12 for solid HTTP/2 support, done?
  • Receive approval at community contributor company
  • Issue PR from community contributor
  • Test HTTP2 for internal communication, and maybe enable by default
  • Test with secured internal communication, and maybe enable by default
  • Expand towards using for client communication
  • Expand towards using for data source (connector-level) communication
  • Expand towards other HTTP client usage
  • Configuration will be necessary to finely control where HTTP2 is used, ideally have a naming convention and consistent behavior and defaults
  • For many usages it will be possible and probably beneficial to support and use longer polled sockets that stay open
@wendigo
Copy link
Contributor

wendigo commented May 1, 2024

Jetty 12 is done but some changes in the airlift would be still needed (ALPN, HTTP/3?)

@wendigo
Copy link
Contributor

wendigo commented May 6, 2024

airlift/airlift#1156

@mosabua
Copy link
Member Author

mosabua commented May 6, 2024

Related NPE fix in Airlift - airlift/airlift#1154

@mosabua
Copy link
Member Author

mosabua commented May 6, 2024

Related issue in Jetty jetty/jetty.project#11631

Fix will be out with 12.0.9

@mosabua
Copy link
Member Author

mosabua commented May 6, 2024

Related Trino isssue - #21735

@wendigo
Copy link
Contributor

wendigo commented May 6, 2024

@mosabua I'd say that 21735 is unrelated to HTTP/2 itself - it applies to HTTP/1 and any other protocol as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants