Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ViewNavigator's Back Button not working after loading a view containing a youtube video #41

Open
rahal opened this issue Feb 14, 2013 · 2 comments

Comments

@rahal
Copy link

rahal commented Feb 14, 2013

After pushing a view containing a youtube video ( via iframe ) , the back button is not working, after some investigations, it appeared that :
ViewNavigator.animating is set to true and therefore , ViewNavigator.prototype.popView returns without poping the view..
This behavior doesn't happen all the time, but after some few pushes and pops ( and has been noticed on android ).
To fix my problem, I removed the test ( this.animating ) from ViewNavigator.prototype.popView but I'm sure there is a better way to fix this.
Thank you.

@rkumar670
Copy link

@rahal
is you problem is fix then yes then please add a comment there is not then you post some code there what you used.
Thanks.

@rahal
Copy link
Author

rahal commented Feb 20, 2013

The problem seems to be resolved, but I'm not sure it is the best way to solve it, here is a diff ( viewnavigator.js ) :

@@ -80,7 +80,7 @@ ViewNavigator.prototype.pushView = function( viewDescriptor ) {

 ViewNavigator.prototype.popView = function() {

-   if (this.animating || this.history.length <= 1 )
+   if ( this.history.length <= 1 )
        return;

    var currentViewDescriptor = this.history[ this.history.length-1];

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants