Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Ping Filter #31

Open
SerAlanTheBold opened this issue Jun 17, 2023 · 3 comments
Open

Feature request: Ping Filter #31

SerAlanTheBold opened this issue Jun 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@SerAlanTheBold
Copy link

add ping filter feature just like DS3 Connection Info.

@tremwil
Copy link
Owner

tremwil commented Jun 17, 2023

Because there is no way to make the game automatically query invasions (outside of macros at least) due to EAC, a DS3ConnectionInfo style ping filter would be impossible. However, I know how to force the game to disconnect from a session through the Steam API alone, so in theory a crude ping filter that only cancels the invasion and doesn't query a new one is possible. Since this can be abused and isn't already public like SessionDisconnect was in DS3, I don't think adding that feature in an open source program is a good idea, though.

Note that I'm also working on other projects at the moment and am not considering feature additions for SteamP2PInfo, so the best course of action if you really want a ping filter is probably to clone the project, do the research and add it for yourself.

@tremwil tremwil changed the title tbh this thing is useless without the ping filter. Feature request: Ping Filter Jun 17, 2023
@tremwil tremwil added the enhancement New feature or request label Jun 17, 2023
@escape0707
Copy link

escape0707 commented Jul 10, 2023

Since this can be abused and isn't already public like SessionDisconnect was in DS3, I don't think adding that feature in an open source program is a good idea, though.

I was in one of the country that have bad internet connection. I'm now in Japan but I always get matched with China, Russia, or Brazil players with extremely high ping or package loss rate. Especially China because the time zone is closer and Chinese government intentionally worsen UDP traffic.

Nowadays, since Elden Ring is really dying from its bad design, either most people moved to PS5 or not playing anymore because of the bad net code. I don't think this will be harmful but very helpful for those people that still actually play this game.

I wish you could consider my advice.

I recently came back to this game after I got a PC here, but the networking issue is really making it hard for me to enjoy online experience. I think if I'm not using a ping filter, maybe I'll just use firewall rules to block all UDP connection from those countries, which definitly will kill online activity more than ping filter.

@cridus
Copy link
Collaborator

cridus commented Jul 10, 2023

About using a firewall...
Months ago I was told about this program called "Portmaster" that seemed able to filter traffic based on country of origin.
Unfortunately, for some stupid reason instead of dropping connections immediately when they come from filtered sources, they put on them a timeout of like 3 minutes.
If anyone wants to help me pressure them into changing that, or to make a fork for ourselves for the change (it needs to build on a specifically-configured system, tho), here's a github issue about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants