Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect protocol for Metadata V1 requests #159

Open
snichme opened this issue Jan 2, 2020 · 0 comments
Open

Incorrect protocol for Metadata V1 requests #159

snichme opened this issue Jan 2, 2020 · 0 comments

Comments

@snichme
Copy link

snichme commented Jan 2, 2020

The protocol/api_versions.go says it supports metadata v 0..1 but it doesn't handle metadata requests where topic length is set to -1 (which is allowed in v1).
It's also missing rack string for each broker and an internal flag for each topic in the metadata response.
snichme added a commit to snichme/jocko that referenced this issue Jan 2, 2020
@snichme
fix metadata requests version 1
de7d6f3 
Handle topic array length when it's -1
And adds some fields to the metadata response

closes travisjeffery#159
@snichme snichme mentioned this issue Jan 2, 2020
Closed
alekitto pushed a commit to alekitto/jocko that referenced this issue Jun 26, 2020
@snichme @alekitto
fix metadata requests version 1
47faa69 
Handle topic array length when it's -1
And adds some fields to the metadata response

closes travisjeffery#159
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix metadata requests version 1 snichme/jocko
1 participant
@snichme