Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject unknown API versions #139

Open
candlerb opened this issue Jun 23, 2018 · 0 comments
Open

Reject unknown API versions #139

candlerb opened this issue Jun 23, 2018 · 0 comments

Comments

@candlerb
Copy link
Contributor

According to the protocol document, brokers are supposed to reject messages containing a higher API version than they understand. This is important because the encoded response does not contain the API version used.

Jocko declares to the client which API versions it supports (defined in protocol/api_versions.go). But I can't see whether it enforces this in incoming requests, and I think it should. It would just be a question of checking the received API version (second field in Request Header) against the min/max values in protocol.APIVersions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant