Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: 'build canceled' badge modification with per stage badges #8923

Open
CermakM opened this issue Dec 15, 2017 · 5 comments
Open

Comments

@CermakM
Copy link

CermakM commented Dec 15, 2017

Hi,

Would it be possible to have badges instead of build - [ failing, passing ] like

<stage> - [ failing, passing ]

and being able to access different badges and include them in my README.md file?

My major problem here is that whenever any of my stages is canceled, the whole build is marked as canceled, although it ran successfully .. which is not what I want.

Use cases:

  • Major usecase
    • When there are multiple jobs and one of the jobs is being canceled for some reasons, the whole build is marked canceled. However the canceled stage might have had minor meaning to the overall build. Splitting to per-stage badges would prevent this.
  • Minor usecase
    • Being able to differentiate job fails directly from github README

If none if it is accaptable (or doable) - could it be rethought how the passed / failed / canceled badges are awarded? I.e cancel badge only if majority / all stages were canceled?

Thanks!

@stale
Copy link

stale bot commented Apr 12, 2018

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Apr 12, 2018
@erwan-joly
Copy link

would be so nice if we could have one badge per stage and replace build by the stage name !

@stale stale bot removed the stale label Apr 16, 2018
@BanzaiMan
Copy link
Contributor

The status is a build level concern, so assigning it to build stages seems wrong to me.

my stages is canceled, the whole build is marked as canceled, although it ran successfully

Then the builds that were canceled should be allowed to fail.

Did I miss something?

@erwan-joly
Copy link

can be useful for people who want a different stage between doesn't compile and doesn't pass the tests

@mewmew
Copy link

mewmew commented Nov 30, 2018

The status is a build level concern, so assigning it to build stages seems wrong to me.

@BanzaiMan The rationale is to have one badge per stage, e.g. one for build passing, one for test cases passing, one for style/lint checks passing, etc.

To take a concrete example, the llir/llvm repo reports build failing Build Status. It may be more useful to understand at what stage the error occurs. For instance, the project builds just fine, the test cases are passing, but there are stylistic lint checks that fail. This becomes especially important as some lint checks are likely to always fail, as the intention is not to follow the suggestions of the linter blindly, but rather apply those that make sense for the project, and ignore other lint issues.

Specifically, I'd love to have the following directly accessible from the readme of my projects:

  • Build status: link to build status badge on Travis CI
  • Test status: link to test status badge on Travis CI
  • Lint status: link to lint status badge on Travis CI

Seeing as my requirements may differ from other users of Travis CI, it seems like the proposal of this issue is generic and affective. Allow users to define build stages, and allow them to link to and create badges for the status of each stage (<stage> - [ failing, passing ]).

Proposed URL for build stage badges: https://travis-ci.org/llir/llvm.svg?branch=BRANCH_NAME&stage=STAGE_NAME

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants