Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypi deploy failing for python 2 with "SyntaxError: invalid syntax" #1232

Open
bcavagnolo opened this issue Feb 9, 2021 · 2 comments
Open
Labels

Comments

@bcavagnolo
Copy link

Hello. My python deploy started failing recently. Here's an example: https://travis-ci.org/github/planetlabs/datalake/jobs/758113984

image

Poking around the dpl source, I suspect that the issue is that the mainline get-pip.py script recently dropped support for python 2. A solution is articulated here on stack overflow:

https://stackoverflow.com/questions/65866417/pip-install-failing-on-python2/65866547#65866547

Does dpl/travis intend to continue supporting shipping python 2 packages to pypi?

bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 17, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Work around this by just publishing sdist and py3 wheel. Python 2
users will just have to use the sdist.
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 17, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image to address this.
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and link python3 to python
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and link python3 to python
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and use python3
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and use python3
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and use python3
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and use python3
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

Use focal image and use python3
bcavagnolo added a commit to planetlabs/datalake that referenced this issue Feb 18, 2021
travis' dpl command seems to be broken for python 2:

travis-ci/dpl#1232

This terrible work-around forces wget to just download the 2.7
pip. Blech.
@bcavagnolo
Copy link
Author

After some experimentation I introduced a pretty deplorable work-around for this to unblock my immediate needs: planetlabs/datalake@e755c91

The issue is here in the dpl source code: https://github.com/travis-ci/dpl/blob/master/lib/dpl/assets/pypi/install#L3

I created this pull request in an attempt to fix the problem: #1233

....but I suspect that I'm still missing something. Like, is there a travis image on which this script works? Or is there some configuration that points dpl to use a specific version of python?

di added a commit to di/fastcov that referenced this issue Jun 19, 2021
RPGillespie6 pushed a commit to RPGillespie6/fastcov that referenced this issue Jun 19, 2021
@stale
Copy link

stale bot commented Jan 8, 2022

Thanks for contributing to this issue. As it has been 90 days since the last activity, we are automatically closing the issue. This is often because the request was already solved in some way and it just wasn't updated or it's no longer applicable. If that's not the case, please do feel free to either reopen this issue or open a new one. We'll gladly take a look again! You can read more here: https://blog.travis-ci.com/2018-03-09-closing-old-issues

@stale stale bot added the stale label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant