Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[discussion] Should HTTP status codes be treated differently when convertResponseToObject is enabled #46

Open
basti1302 opened this issue Aug 27, 2015 · 0 comments

Comments

@basti1302
Copy link
Member

For example:

  1. for get, post, put, ... without convertResponseToObject no HTTP status (including 4xx and 5xx) would be treated as an error.
  2. for getResource and get, post, put, ... with convertResponseToObject HTTP status outside of 200 - 299 (in particular 4xx and 5xx) would be treated as an error.

See also traverson/traverson-angular#14.

I'm not sure if it is a good idea to change the semantics of "error" and therefore error handling code depending on a configuration option. It has a certain smell to it.

@basti1302 basti1302 changed the title Should HTTP status codes be treated differently when convertResponseToObject is enabled [discussion] Should HTTP status codes be treated differently when convertResponseToObject is enabled Feb 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant