Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not work in tor browser #52

Open
vitonsky opened this issue Aug 14, 2021 · 7 comments
Open

Not work in tor browser #52

vitonsky opened this issue Aug 14, 2021 · 7 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@vitonsky
Copy link
Collaborator

Can't open popup for translate page, can't open dictionary

Inspector log: "A mutation operation was attempted on a database that did not allow mutations"

Solution: use browser.storage.local instead indexDB everywhere when it possible, we must use indexDB only for optional cache and other improvements

The real problem

This components are use indexDB

  • Content script for getting config
  • Dictionary for entries
  • Checkbox for favorites

To fix this problem its all should stop use indexDB. It is not possible because indexDB is most efficient method of store data.

Consequent, this problem will not fix if we can't disable only dictionary, translators cache and site preferences.

Task

We must research whats features we should disable to make it work.

If you want make it work in tor, you can research it and write in comments about results

@vitonsky vitonsky added bug Something isn't working help wanted Extra attention is needed labels Aug 14, 2021
@vitonsky vitonsky pinned this issue Jul 19, 2022
@vitonsky
Copy link
Collaborator Author

Hack to make available Linguist for Tor Browser 11.0.6 and newer

  • Go to about:config
  • Enable option dom.indexedDB.privateBrowsing.enabled
  • Enable option dom.storage.enabled
  • Restart browser

@vitonsky
Copy link
Collaborator Author

uBlock Origin are works fine in Tor Browser. We should research how it keep rules in persistent storage, maybe it possible to use this way for our storage

@vitonsky
Copy link
Collaborator Author

We may just disable features which is require a indexDB. We may test indexDB support while first start and if it's not support, disable these

@sanjayen
Copy link

Using Mullvad Browser (based on Tor Browser but without the tor protocol) and both options are by default enabled. However, the extension overlay fails and so does the options page. Any idea on how to make it work?

@vitonsky
Copy link
Collaborator Author

@sanjayen please give more info about your case

  • browser name and version
  • operation system info
  • attach screenshot with error
  • copy or screenshot errors in console of addon (for Firefox based browsers open page about:debugging#/runtime/this-firefox and click inspect on Linguist, then open tab Console)

@sanjayen
Copy link

@vitonsky apologies, should have shared earlier. Here it is;

browser name and version: Mullvad Browser 13.0a3 - https://github.com/mullvad/mullvad-browser/releases/tag/13.0a3
operating system info: Windows 11 Pro 22H2 OS Build - 22621.2215

Both configs - dom.indexedDB.privateBrowsing.enabled and dom.storage.enabled have already been enabled, by default, in Mullvad.

2023-09-10_161541
Linguist-console-error
config-1
config-2

@vitonsky
Copy link
Collaborator Author

@sanjayen thank you for info, i will investigate and come back

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants