Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update required node version to 20 #429

Open
vitonsky opened this issue May 6, 2024 · 4 comments
Open

Update required node version to 20 #429

vitonsky opened this issue May 6, 2024 · 4 comments
Labels
dev Development and infrastructure tasks

Comments

@vitonsky
Copy link
Collaborator

vitonsky commented May 6, 2024

CodeQL action have warning

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v2, github/codeql-action/init@v1, github/codeql-action/autobuild@v1, github/codeql-action/analyze@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Currently the project uses node version 14. We have to update node to version 20, test all works fine, fix a potential problems and update engines in packages.json. Also, let's mention dev requirements in the docs, we should add info about node version, docker and another tools that are required to make build

@vitonsky vitonsky added the dev Development and infrastructure tasks label May 6, 2024
@hamirmahal
Copy link
Contributor

Is there a way to benchmark performance currently? It might be interesting to see speed changes after upgrading to node 20.

@vitonsky
Copy link
Collaborator Author

vitonsky commented May 7, 2024

I think we currently no have benchmarks. We should update node just because 14 version is deprecated and do not supported anymore. I will try to add more unit tests in future, it will be useful additionally for measure performance between node versions too.

Potentially, we may have a problems with build the code with a new node version

@hamirmahal
Copy link
Contributor

How do you test ./Dockerfile and thirdparty/bergamot/Dockerfile?

@vitonsky
Copy link
Collaborator Author

How do you test ./Dockerfile and thirdparty/bergamot/Dockerfile?

We just run a command make buildAll that build all things. If this command fails, then we have broken code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev Development and infrastructure tasks
Projects
None yet
Development

No branches or pull requests

2 participants