Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CodeQL version in CI config #428

Closed
vitonsky opened this issue May 6, 2024 · 3 comments · Fixed by #433
Closed

Update CodeQL version in CI config #428

vitonsky opened this issue May 6, 2024 · 3 comments · Fixed by #433
Labels
dev Development and infrastructure tasks good first issue Good for newcomers

Comments

@vitonsky
Copy link
Collaborator

vitonsky commented May 6, 2024

CI logs have a warning

This version of the CodeQL Action was deprecated on January 18th, 2023, and is no longer updated or supported. For better performance, improved security, and new features, upgrade to v2. For more information, see https://github.blog/changelog/2023-01-18-code-scanning-codeql-action-v1-is-now-deprecated/

We should update CodeQL vesrion in codeql-analysis.yml
@vitonsky vitonsky added enhancement New feature or request good first issue Good for newcomers dev Development and infrastructure tasks and removed enhancement New feature or request labels May 6, 2024
@vitonsky vitonsky mentioned this issue May 7, 2024
Closed
@hamirmahal
Copy link
Contributor

Hmm... What're your thoughts on removing codeql-analysis.yml altogether, and enabling it via the repository settings, instead?

image

https://github.com/hamirmahal/FilmFinder/ doesn't have a codeql-analysis.yml file, but it still has CodeQL checks run occasionally, anyway.

image

https://github.com/hamirmahal/FilmFinder/tree/main/.github/workflows

@vitonsky
Copy link
Collaborator Author

vitonsky commented May 7, 2024

I just found out that we can run CodeQL with no config and it will auto detect most suitable config. I will try it on days, thanks!

@hamirmahal
Copy link
Contributor

You're welcome!

@vitonsky vitonsky mentioned this issue May 22, 2024
Merged
@vitonsky vitonsky linked a pull request May 22, 2024 that will close this issue
ci: remove codeql config #433
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev Development and infrastructure tasks good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: remove codeql config translate-tools/linguist
2 participants
@hamirmahal @vitonsky