Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the Netflix subtitles hoverable so that the popup can be utilized with it. #420

Open
RyanOrigens opened this issue May 2, 2024 · 5 comments
Labels
questions Further information is requested

Comments

@RyanOrigens
Copy link

No description provided.

@vitonsky vitonsky added the questions Further information is requested label May 2, 2024
@vitonsky
Copy link
Collaborator

vitonsky commented May 2, 2024

What is your use case?

Linguist does not interrupt in code of specific sites. We have a similar issue about RTL where I said about a potential problems for this approach with "improve" site behavior.

@RyanOrigens
Copy link
Author

Hi,

I noticed this statement on GitHub/Chrome Web Store:

"Translate web pages, highlighted text, Netflix subtitles, private messages, speak the translated text, and save important translations to your personal dictionary to learn words even offline."

I thought there could be a special treatment for Netflix itself, as extensions of this kind have been doing it for a while...

My proposal is to make the subtitles on Netflix selectable, so the user would be able to highlight the text and utilize the pop-up icon to translate a specific word. (or just show up the pop up with the translation instead of the icon)

Here are some examples of extensions of the same genre doing this:

Mate Translate / Reverso

For example, Mate makes the subtitles clickable for languages with spaces (Spanish, English, Portuguese, basically every single one of them). For other languages without spaces, such as Japanese or Chinese, where it may not be possible to parse the language without previous knowledge of it, you can only hover...

image

@vitonsky
Copy link
Collaborator

vitonsky commented May 2, 2024

What about translate whole page instead?
You may enable page translation and subtitles should be translated automatically. Is it works for you?

@RyanOrigens
Copy link
Author

The whole purpose would be utilize it as a dictionary rather than a translator itself. (With the goal of acquiring a language or learning new words in a language you already know.) if this is not the goal of the project feel free to close the issue.

@vitonsky
Copy link
Collaborator

vitonsky commented May 3, 2024

You're correct, the goal of Linguist both - translate content and help to learn a languages.
The only problem we have with this proposal is we have to modify a site, to implement this request.

My opinion is we must never modify a site content or change site behavior. But i see your concern about barriers to use Linguist with some sites.

Maybe we may introduce a user packages to find a tradeoff here. In this case, Linguist will not change site behavior itself, but Linguist will provide some list with packages/extensions, so users will be able to improve a behavior on specific sites they needed. User would just go to preferences page, then click something kinda "extensions" and will see a list of extensions, then will click "install"/"enable" on extensions like "netflix subtitles" and it will be installed and activated.

I'm not sure about RCE policy in Chrome store for addons with manifest V3, maybe it is not allowed, i have to research.

I will think how to resolve this problem. It probably will not be solved soon, but anyway thank you for report your use case. It is important to know what users needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
questions Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants