Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modifier keys for "Enable popup with original text" #408

Open
Dook1 opened this issue Nov 27, 2023 · 6 comments
Open

Modifier keys for "Enable popup with original text" #408

Dook1 opened this issue Nov 27, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@Dook1
Copy link

Dook1 commented Nov 27, 2023

Would you please add the option to select modifier keys(Ctrl, Shift, Alt) for "Enable popup with original text"?

@vitonsky vitonsky added the RFC Need to triage label Nov 27, 2023
@vitonsky
Copy link
Collaborator

Yes, i can implement this feature if it would be useful for users. Could you please describe your use case, why you need this feature and how you imagine usage of this feature?

Your description are important to decide should this feature be implemented or not, so please try to be detailed, try to tell why you want this behavior.

@Dook1
Copy link
Author

Dook1 commented Nov 27, 2023

Constant pop-ups bother me because they interfere with reading and I have to always keep the mouse away from the text. I only need to look at the original on rare occasions:

  1. when the translation is not clear enough.
  2. when the translator translated a word that is a term
  3. when the word is translated without taking into account the context

@vitonsky
Copy link
Collaborator

I see your concern about popup with original text for full-page translation, that appears by hover on text feels bad for some cases.

What solution you see? How exactly it should work?

@Dook1
Copy link
Author

Dook1 commented Nov 27, 2023

If the mouse is over the element, then check if the modifier key is pressed, if it is, then show popup with the original text.

@vitonsky
Copy link
Collaborator

Good idea. I think it must be implemented

@vitonsky vitonsky added enhancement New feature or request and removed RFC Need to triage labels Nov 27, 2023
@Dook1
Copy link
Author

Dook1 commented Nov 27, 2023

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants