Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add messages summarising alignments and updates #131

Open
ehwenk opened this issue Aug 22, 2023 · 2 comments
Open

Add messages summarising alignments and updates #131

ehwenk opened this issue Aug 22, 2023 · 2 comments
Assignees

Comments

@ehwenk
Copy link
Collaborator

ehwenk commented Aug 22, 2023

After running create_taxonomic_update_lookup it would be good to print out some summary statistics, so the user has a sense of the changes that were made.

For instance:
x taxa aligned with APC-accepted species
x taxa aligned with APC-accepted genera
x taxa aligned with APNI recorded names
x taxa could not be aligned to a known genus or species
x aligned taxon names were updated to APC-accepted species
you chose the most_likely_species option for the parameter taxonomic_splits. The column ... documents other possible names.
etc.

@fontikar
Copy link
Collaborator

fontikar commented Apr 18, 2024

@ehwenk to simplify or ditch messaging for load_taxonomic_resources and during alignment . In the future we will enhance the the messaging to update during matching

@ehwenk
Copy link
Collaborator Author

ehwenk commented Apr 18, 2024

For now I propose commenting out lines 166-176 in align_taxa.R. There is still the message from line 79 that indicates how many taxa are in the list.

message("Checking alignments of ", dplyr::n_distinct(original_name, na.rm = TRUE), " taxa\n")

The options going forward are for:

  1. Summary statistics that are added at the end
  2. Summary statistics that are added after each algorithm (or cluster of algorithms) that indicate how many taxa have been matched, but those messages would need to be embedded within match_taxa.R - and maybe is something to do if we modularise the function?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants