Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traefik perpetually out of sync in Argo CD due to missing divisor spec for GOMEMLIMIT and GOMAXPROCS #1065

Open
2 tasks done
hawkesn opened this issue May 8, 2024 · 2 comments
Labels
kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed.

Comments

@hawkesn
Copy link

hawkesn commented May 8, 2024

Welcome!

  • Yes, I've searched similar issues on GitHub and didn't find any.
  • Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What version of the Traefik's Helm Chart are you using?

28.0.0

What version of Traefik are you using?

traefik:v3.0.0

What did you do?

I setup Traefik on ArgoCD and I am constantly seeing a diff:
image

What did you see instead?

Based on this comment on a similar problem (different application) cilium/cilium#30634
I was able to correct it using this comment: cilium/cilium#30635 (comment)

Specifically I added:

    resource.customizations.ignoreDifferences.apps_Deployment: |
      jqPathExpressions:
      - '.spec.template.spec.containers[] | select(.name == "traefik").env[] | select(.name == "GOMAXPROCS" or .name == "GOMEMLIMIT").valueFrom.resourceFieldRef.divisor'

to my ArgoCD cm

The fix for this looks straight forward:
https://github.com/cilium/cilium/pull/30635/files

A default value for divisor needs to be added

What is your environment & configuration?

Kubernetes 1.29.3 - used as a Deployment

Additional Information

No response

@hawkesn
Copy link
Author

hawkesn commented May 8, 2024

Adding divisor: 1 AFTER

And

Should fix this pretty quickly

@mloiseleur mloiseleur added kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed. and removed status/0-needs-triage labels May 12, 2024
@mloiseleur
Copy link
Contributor

Thanks for this detailed report.
Do you think you can open a PR for it ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug/possible a possible bug that needs analysis before it is confirmed or fixed.
Projects
None yet
Development

No branches or pull requests

2 participants