New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shouldn't the fitting be done only on the old data? #19

Open

fredthedead opened this issue Nov 20, 2020 · 0 comments

fredthedead commented Nov 20, 2020 •

edited

If the model is being fit on the historical data + new data, doesn't it mean it'll perform less accurately when tested?

surpriver/detection_engine.py

Line 203 in 5241766

detector.fit(features)

surpriver/detection_engine.py

Line 204 in 5241766

predictions = detector.decision_function(features)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment