Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applications need to have product specific information #19

Open
pgmemk opened this issue Feb 3, 2021 · 0 comments
Open

Applications need to have product specific information #19

pgmemk opened this issue Feb 3, 2021 · 0 comments

Comments

@pgmemk
Copy link
Member

pgmemk commented Feb 3, 2021

Right now we have tradle.Application for all types of applications.
And when some application needs to show in its details some specific properties we add them to the application resource.

That is not very kosher. It would be better to

  • EITHER have the application specific to a product
  • OR tradle.Application can have some additional property say moreItems as a backlink and to add any additional information for application in it and allow the plugins to add them there. And then the application front end will display them as a part of Application Detail tab
    It could be something like that.
{
  id: 'tradle.Application',
  ...
  properties: {
    ....
    moreDetails: {      
       type: 'array'
       items: {
         ref: 'tradle.DetailItem',
         backlink: 'application'
       }
    }
  }
}
{
  id: 'tradle.DetailItem',
  ...
  properties: {
    application: {
      type: 'object',
      ref: 'tradle.Application'
    },
    propertyName: {      
       type: 'string'
    },
    propertyObjValue: {
       type: 'object'
       ...
    },
    propertyStringValue: {
       type: 'string'
    },
    propertyNumberValue: {
       type: 'number',
       numberFormat: {
         ...
       }
    },
   ...
  }
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant