Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License: this is either not an open-source project, or the attribution clause is void #1437

Open
oliviertassinari opened this issue Oct 8, 2023 · 1 comment
Labels
documentation Improvements or additions to the documentation needs investigation Needs further investigation.

Comments

@oliviertassinari
Copy link

oliviertassinari commented Oct 8, 2023

Steps/code to reproduce:

  1. Open docs https://tradingview.github.io/lightweight-charts/docs#license-and-attribution
SCR-20240309-qesm
  1. Open actual license is Apache-2.0 https://github.com/tradingview/lightweight-charts/blob/master/LICENSE
  (c) You must retain, in the Source form of any Derivative Works
      that You distribute, all copyright, patent, trademark, and
      attribution notices from the Source form of the Work,
      excluding those notices that do not pertain to any part of
      the Derivative Works; and

  (d) If the Work includes a "NOTICE" text file as part of its
      distribution, then any Derivative Works that You distribute must
      include a readable copy of the attribution notices contained
      within such NOTICE file, excluding those notices that do not
      pertain to any part of the Derivative Works, in at least one
      of the following places: within a NOTICE text file distributed
      as part of the Derivative Works; within the Source form or
      documentation, if provided along with the Derivative Works; or,
      within a display generated by the Derivative Works, if and
      wherever such third-party notices normally appear. The contents
      of the NOTICE file are for informational purposes only and
      do not modify the License. You may add Your own attribution
      notices within Derivative Works that You distribute, alongside
      or as an addendum to the NOTICE text from the Work, provided
      that such additional attribution notices cannot be construed
      as modifying the License.

Actual behavior:

Contradicting content. The license says attribution in the source, docs say backlink. So today's mention in the docs is legally not binding. The language is deceptive by says "shall", this is misinformation.

Expected behavior:

Consistency.

Solutions

  • The simplest is change the docs to match the license.
  • Otherwise, using a non-open-source license is also possible, but a more expensive change.

I noticed this while I was benchmarking the space for candlestick libraries available for developers in mui/mui-x#10932.

@SlicedSilver SlicedSilver added documentation Improvements or additions to the documentation needs investigation Needs further investigation. labels Oct 8, 2023
@oliviertassinari oliviertassinari changed the title License issue License: this is either not an open-source project, or the attribution clause is void Mar 9, 2024
@oliviertassinari
Copy link
Author

oliviertassinari commented May 7, 2024

TinyMCE had the same problem, they fixed it: tinymce/tinymce-docs#2562.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to the documentation needs investigation Needs further investigation.
Projects
None yet
Development

No branches or pull requests

2 participants