Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requirement of :chistory should require setting qf title? #283

Open
blueyed opened this issue Jul 25, 2019 · 1 comment
Open

Requirement of :chistory should require setting qf title? #283

blueyed opened this issue Jul 25, 2019 · 1 comment

Comments

@blueyed
Copy link
Contributor

blueyed commented Jul 25, 2019

In 9096c8b was added to require :chistory (added in v7.4.2049, vim/vim@f6acffbe8).

In 13f2aa8 if exists(':chistory') is used to call setqflist([], 'r', {'title': …, but this is only available with has('patch-7.4.2200') vim/vim@d823fa910.

So at least the handling of the title should have a check for patch-7.4.2200.

For reference of some important patches: https://github.com/neomake/neomake/blob/852029b49c495181c2900d6baf4de7208507649e/autoload/neomake/list.vim#L5-L9

@blueyed blueyed changed the title Requirement of chistory should require setting qf title? Requirement of :chistory should require setting qf title? Jul 25, 2019
@tpope
Copy link
Owner

tpope commented Jul 25, 2019

I would add let s:quickfix_info = has('patch-7.4.2200') and use that to replace all exists(':chistory') conditionals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants