Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs request: if pk will be unique #1562

Closed
jamesbraza opened this issue Feb 29, 2024 · 1 comment
Closed

Docs request: if pk will be unique #1562

jamesbraza opened this issue Feb 29, 2024 · 1 comment

Comments

@jamesbraza
Copy link

Is your feature request related to a problem? Please describe.

This model:

from tortoise.models import Model

class Foo(Model):
    id = fields.CharField(max_length=32, pk=True)

And reading docs here: https://tortoise.github.io/models.html?h=primary+key#primary-keys

Don't indicate if pk will be unique or not.

Describe the solution you'd like

Can we document in the primary keys docs that pk means unique, or doesn't mean unique?

Describe alternatives you've considered

N/a

Additional context

None

@vlakius
Copy link

vlakius commented Apr 24, 2024

it's a primary key...they are unique by design..

@abondar abondar closed this as completed May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants