Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iostream: SSL logging is too noisy #3347

Open
bdarnell opened this issue Nov 14, 2023 · 0 comments
Open

iostream: SSL logging is too noisy #3347

bdarnell opened this issue Nov 14, 2023 · 0 comments

Comments

@bdarnell
Copy link
Member

SSL connections currently log (at logging.WARNING on gen_log) for many errors that may be out of the application's control. For example, when a client IOStream connects to a server with a self-signed certificate, it both raises an exception and logs a warning. It's hardly ever appropriate to do both for client operations; the application can catch the exception and log the error if it wants.

On the server side it's trickier since there is no good place for exceptions to go, but we should probably still downgrade some of this logging. If the client side fails to validate the server's certificate, it sends a "tls alert" to the server, causing the server to raise and log an exception. These messages should at a minimum be downgraded to INFO since they do not indicate a problem with the server.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant