Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow extending resolution of link definitions #52

Open
dmcclean opened this issue Nov 11, 2014 · 0 comments
Open

Allow extending resolution of link definitions #52

dmcclean opened this issue Nov 11, 2014 · 0 comments

Comments

@dmcclean
Copy link

Would you support a pull request to mark the GetLinkDefinition function as virtual?

public LinkDefinition GetLinkDefinition(string id)
{
    LinkDefinition link;
    if (m_LinkDefinitions.TryGetValue(id, out link))
        return link;
    else
        return null;
}

I'd like to be able to allow my (internal) users to use a custom syntax for linking to database resources. I think that if it's done by extending the link definition resolution it may be useful to people more generally.

If so, does the project style prefer introducing a template method here so that all subclasses are required to prefer entries in the m_LinkDefinitions lookup to whatever their own virtual entries may be, or is just marking the whole thing virtual OK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant