Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$50] Adding a badge again and again has no counter #32

Open
sdgun opened this issue Jun 21, 2018 · 7 comments
Open

[$50] Adding a badge again and again has no counter #32

sdgun opened this issue Jun 21, 2018 · 7 comments
Labels
Priority 4 Low - Fixed only when time permits tcx_OpenForPickup

Comments

@sdgun
Copy link

sdgun commented Jun 21, 2018

Target URL

https://frontend-dev.app.cloud.gov/dashboard/10

Steps to Reproduce

  1. Open the URL https://frontend.app.cloud.gov/
  2. Login as a valid User [Admin]
  3. Click Search button
  4. Enter 'Branch of service' as US NAVY
  5. Click 'Update Results' button
  6. Click on any record > https://frontend.app.cloud.gov/dashboard/10
  7. Click on 'Badge' button and select the 2 badges and click 'Add Badge' button
  8. Click on 'Badge' button and select the same 2 badges and click 'Add Badge' button
  9. Click on 'Badges' section and Observe

Actual Result(s)

  • Same badges can be added again and again

Expected Result(s)

  • Must have counter with number of times badge as been added

Frequency

  • 5/5

Environment Details

  • Device(s): Laptop
  • Operating System: Windows 7 64bit
  • Browser(s): Chrome 67.0.3396.87 (Official Build) (64-bit)

Image(s)/Video(s)/Console Log/Crash Log

27

@ramillim
Copy link
Contributor

This is a backend issue as well, but we should discuss the front end design here.
@dustinWeaver @sdgun

Since badges won't display until they are approved and there isn't a spot for displaying pending badges, if any badges, it's more difficult for the user selecting badges to assign to see if a badge has already been submitted.

So let's say there are any that already are approved or are in pending status, we probably want to hide them from the list of badges to select so the user doesn't try to submit another request. How should the UI look? Should the badges be grayed out/disabled or should they just not be on the list?

Should the ones that are be pending have a marker that indicates they are pending? To expose these pending badges, the API will need to be updated since it only returns Approved badges.

@dustinTopcoder dustinTopcoder changed the title Same badges can be added again and again [$50] Same badges can be added again and again Aug 16, 2018
@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069622 has been created for this ticket.

@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069622 has been updated - the new changes has been updated for this ticket.

@MountainGoats MountainGoats added the Priority 4 Low - Fixed only when time permits label Aug 16, 2018
@jiangliwu jiangliwu self-assigned this Sep 7, 2018
@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069622 has been updated - it has been assigned to jiangliwu.

@jiangliwu jiangliwu added the In Progress developer working on this label Sep 7, 2018
@jiangliwu jiangliwu removed their assignment Sep 7, 2018
@jiangliwu jiangliwu removed the In Progress developer working on this label Sep 7, 2018
@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069622 has been updated - the new changes has been updated for this ticket.

This is an automated message for dweaver via Topcoder X

@dustinTopcoder dustinTopcoder changed the title [$50] Same badges can be added again and again [$50] Adding a badge again and again has no counter Sep 13, 2018
@dustinTopcoder
Copy link
Contributor

Contest https://www.topcoder.com/challenges/30069622 has been updated - the new changes has been updated for this ticket.

This is an automated message for dweaver via Topcoder X

@dustinTopcoder
Copy link
Contributor

@sdgun, I've edited this issue a bit. The client wants to have multiple badges of the same time, but have a counter to indicate how many times the badge has been given.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority 4 Low - Fixed only when time permits tcx_OpenForPickup
Projects
None yet
Development

No branches or pull requests

6 participants