Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error handling normalization in front-end #467

Open
standlove opened this issue Jan 17, 2019 · 0 comments
Open

error handling normalization in front-end #467

standlove opened this issue Jan 17, 2019 · 0 comments

Comments

@standlove
Copy link
Collaborator

standlove commented Jan 17, 2019

Now we can consolidate the error handling in one place.

If the received error is 500 with message = ConnectFailed or ConnectTimeout, dispatch the RedisConnectFailed event.

If the command is from CLI, we will just display the message in CLI directly; otherwise, we can simply display the error with: this.util.showMessage(message).

The "Fail to import xxx" etc. prefix is not necessary.

And an extra note about the error from import dialog, you should show the lineNo of the failed command as well.

And the dialog should only be auto-closed if the operation is successful. Don't close it if there is any error.

@standlove standlove changed the title error handling in front-end normalization error handling normalization in front-end Jan 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant