Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set Icon in GLFW #5

Open
tom-mohr opened this issue Jan 20, 2023 · 3 comments
Open

Set Icon in GLFW #5

tom-mohr opened this issue Jan 20, 2023 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@tom-mohr
Copy link
Owner

The application doesn't have an icon when running (only the .exe). Use GLFW to load the existing "favicon.ico" file as application icon.
@tom-mohr tom-mohr added enhancement New feature or request good first issue Good for newcomers labels Jan 20, 2023
@y-ashaswini
Copy link

Greetings!
I was just trying to take up this issue since I really like what you've created, I highly appreciate the level of skill you must possess to create such an application, and I merely wanted to try and contribute to it.

Thing is, I managed to add an icon into it, but the code crashes when it's with an .ico extension. I added a png file instead (just for checking) and it runs.

Is it possible for you to add a png version of the icon into the repo? Or, do you necessarily want it to be .ico?
If you want any more information, please do ask!

@y-ashaswini y-ashaswini mentioned this issue Apr 25, 2023
Open
@tom-mohr
Copy link
Owner Author

tom-mohr commented May 2, 2023

Greetings! Sorry for replying late. And thanks for the praise :)
Good to hear that you're working on this! Here's a 512x512 PNG:
image

@y-ashaswini
Copy link

Great! I made the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tom-mohr @y-ashaswini