Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In ClickUp integration the task ID is detected incorrectly #2246

Open
vasil-sokolov opened this issue Oct 4, 2023 · 1 comment
Open

In ClickUp integration the task ID is detected incorrectly #2246

vasil-sokolov opened this issue Oct 4, 2023 · 1 comment
Labels

Comments

@vasil-sokolov
Copy link

  • OS version: Windows 11
  • Browser version: Edge latest
  • Extension version: 3.0.18

Relevant integration (if any):

I'm using the integration with ClickUp on public domain https://app.clickup.com

🐛 Describe the bug

Lately ClickUp rolled out new interface and after that the task id is not captured correctly.
Instead of the task id the integration adds null.

Expected behaviour

The integration should capture task title and id from a page.

Steps to reproduce

Press the Toggl button.

Steps to reproduce the behaviour:

  1. Switch to UI of ClickUp to version 3.0
  2. Open any task in ClickUp and press the Toggle button
  3. In the track edit popup you will see the task title and the #null next to the title

Other details or context

I checked the source code of the ClickUp integration and it looks like there is an issue there or at least the room for improvement.
In the previous commit the author takes the title tag and splits its content by a pipe "|".
Then it uses the [0] element as a track title but does nothing with the [1] element that contains the required task ID.

const description = document.querySelector('title').textContent.split('|')[0];

Instead of using the data we already have code tries to get another element that contains the task ID. And this fails in the latest version of ClickUp. Something like that:
const taskID = document.querySelector('title').textContent.split('|')[1];

As I remember, the title tag included task title and ID all the time, so it's safe to take info from it in all versions of ClickUp.

Unfortunately, I can't provide the fix because I can't enable Developer mode in the extension and test the changes.

@andresgz
Copy link

andresgz commented Oct 9, 2023

I have this issue too!
I used to enable developer mode and fix it when It failed but It's not working anymore!
I have to work with a very old version that still doesn't do it perfectly, but at least adds the code # code
instead of #null

What can we do? It's critical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants